darwin-eu / omopgenerics

https://darwin-eu.github.io/omopgenerics/
Apache License 2.0
2 stars 1 forks source link

Should newSummarisedResult remove duplicates? #408

Closed edward-burn closed 3 months ago

edward-burn commented 3 months ago
library(omopgenerics)
#> 
#> Attaching package: 'omopgenerics'
#> The following object is masked from 'package:stats':
#> 
#>     filter
x <- dplyr::tibble(
  "result_id" = as.integer(1),
  "cdm_name" = "cprd",
  "result_type" = "summarised_characteristics",
  "package_name" = "PatientProfiles",
  "package_version" = "0.4.0",
  "group_name" = "sex",
  "group_level" = "male",
  "strata_name" = "sex",
  "strata_level" = "male",
  "variable_name" = "Age group",
  "variable_level" = "10 to 50",
  "estimate_name" = "count",
  "estimate_type" = "numeric",
  "estimate_value" = "5",
  "additional_name" = "overall",
  "additional_level" = "overall"
)
x <- newSummarisedResult(x = x)
#> ! The following variables: result_type, package_name, package_version; were added to `settings`
x <- bind(x, x)
newSummarisedResult(x = x) 
#> # A tibble: 2 × 13
#>   result_id cdm_name group_name group_level strata_name strata_level
#>       <int> <chr>    <chr>      <chr>       <chr>       <chr>       
#> 1         1 cprd     sex        male        sex         male        
#> 2         1 cprd     sex        male        sex         male        
#> # ℹ 7 more variables: variable_name <chr>, variable_level <chr>,
#> #   estimate_name <chr>, estimate_type <chr>, estimate_value <chr>,
#> #   additional_name <chr>, additional_level <chr>

Created on 2024-07-17 with reprex v2.0.2

catalamarti commented 3 months ago

yep, happy to review a PR