require all columns not only the ones that must not be missing for omopTables

darwin-eu / omopgenerics

https://darwin-eu.github.io/omopgenerics/

Apache License 2.0

2 stars 1 forks source link

require all columns not only the ones that must not be missing for omopTables #519

Open catalamarti opened 1 month ago

catalamarti commented 1 month ago

https://github.com/darwin-eu-dev/omopgenerics/blob/7cbd021667650f22fdbad450157322e4032e49b1/R/classOmopTable.R#L42 TURN THIS TO FALSE

catalamarti commented 1 week ago

this would currently break:

omock @ilovemane
IncidencePrevalence @edward-burn
OmopSketch @martaalcalde
CohortSymmetry @xihang-chen
CodelistGenerator @edward-burn
PatientProfiles @catalamarti

Would be nice if we can make sure that mocks contain all the required columns in the new versions of the package I will open a separate issue in each one of the packages

edward-burn commented 1 week ago

I don't think it is worth breaking six packages for this. At most I suppose it could be added as a warning initially