Add variable_level columns to checkGroup()

darwin-eu / omopgenerics

https://darwin-eu.github.io/omopgenerics/

Apache License 2.0

2 stars 1 forks source link

Add variable_level columns to checkGroup() #542

Open martaalcalde opened 2 weeks ago

martaalcalde commented 2 weeks ago

catalamarti commented 6 days ago

If we add this, the validation no longer make sense. There are two options:

We remove that validation -> we have to think how we do suppression then
Your dataset structures differently (variable_name and variable_level interchange)

martaalcalde commented 5 days ago

Happy to reach an agreement. Maybe I could move variable_level to additional_level, and in additional_name add "time_interval"? I think that, for consistency, I should change also other functions such as "summariseInObservation" or "summariseConceptCounts" though.