search

darwin-eu / omopgenerics

https://darwin-eu.github.io/omopgenerics/
Apache License 2.0
2 stars 1 forks source link

addIndex and persist inside compute #545

Closed edward-burn closed 1 week ago

edward-burn commented 1 week ago

@catalamarti would you be happy for me to add a function addIndex that would be a utility for adding indexes to a table (to be used on a cohort table for example).

If so, to go with this I think it would make sense to persist indexes inside compute (so long as the results still has the same columns) - particularly if creating a new permanent table. What do you think?

catalamarti commented 1 week ago

addIndex name may be tricky as we also have this issue open: https://github.com/darwin-eu-dev/PatientProfiles/issues/325

Also we should be careful with this and review some of the internal code, if we add indexes we do not want to put computes too close in the code

@edward-burn