Consider upgrading dependencies to make this Dart3 compatible

MagnusJohansson commented 11 months ago

What version are you using?

5.0.11

What OS and version are you using to local deploy your application?

Windows 11

What platforms are you seeing the problem on?

Android

pubspec.yaml

flutter_facebook_auth: ^5.0.11

Describe the Bug

Now that the http package is updated to version 1.0.0, please consider make this package compatible with the latest Dart 3 packages

Because flutter_facebook_auth >=5.0.8 depends on facebook_auth_desktop ^0.0.9 which depends on http ^0.13.5, flutter_facebook_auth >=5.0.8 requires http ^0.13.5.
So, because my_app depends on both flutter_facebook_auth ^5.0.11 and http ^1.0.0, version solving failed.

Expected Behavior

This package should be compatible with Dart 3 packages

To Reproduce

Create a simple OOB sample Flutter project.
Add a dependency to flutter_facebook_auth: ^5.0.11 and http: ^1.0.0
Observe the error: Because flutter_facebook_auth >=5.0.8 depends on facebook_auth_desktop ^0.0.9 which depends on http ^0.13.5, flutter_facebook_auth >=5.0.8 requires http ^0.13.5. So, because my_app depends on both flutter_facebook_auth ^5.0.11 and http ^1.0.0, version solving failed.

Relevant log output

Because flutter_facebook_auth >=5.0.8 depends on facebook_auth_desktop ^0.0.9 which depends on http ^0.13.5, flutter_facebook_auth >=5.0.8 requires http ^0.13.5.
So, because my_app depends on both flutter_facebook_auth ^5.0.11 and http ^1.0.0, version solving failed.

flutter doctor -v

[√] Flutter (Channel stable, 3.10.2, on Microsoft Windows [Version 10.0.22621.1778], locale en-GB)
    • Flutter version 3.10.2 on channel stable at E:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (7 days ago), 2023-05-23 20:57:28 -0700
    • Engine revision 90fa3ae28f
    • Dart version 3.0.2
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\magnu\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.6.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.6.33723.286
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.78.2)
    • VS Code at C:\Users\magnu\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.64.0

[√] VS Code (version 1.79.0-insider)
    • VS Code at C:\Users\magnu\AppData\Local\Programs\Microsoft VS Code Insiders
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.1778]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 113.0.5672.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.57

[√] Network resources
    • All expected network resources are available.

• No issues found!

Info.plist (iOS)

No response

Podfile (iOS)

No response

AndroidManifest.xml

No response

MainActivity.java

No response

MainActivity.kt

No response

index.html

No response

Info.plist (macOS)

No response

darwin-morocho commented 11 months ago

@MagnusJohansson the problem is if I upgrade the http package every developer that is using this package must update their projects to dart 3.x

darwin-morocho commented 11 months ago

MagnusJohansson commented 11 months ago

I think you can avoid that by doing an inclusive version range, something like:

http: ">=0.13.5 <2.0.0"

Developers who are using Dart 3 and http 1.x.x should be able to use your package, and legacy v0.x.x should still work.

timkandel commented 11 months ago

I think you can avoid that by doing an inclusive version range, something like:
http: ">=0.13.5 <2.0.0"
Developers who are using Dart 3 and http 1.x.x should be able to use your package, and legacy v0.x.x should still work.

Personally I think the cleaner way would be to release a new major version 6.0 and bump the requirements in this release. That way it be more obvious to users upgrading the library that there are potentially breaking changes in this package or it's dependencies.

darwin-morocho commented 11 months ago

check 6.x.x

darwin-morocho / flutter-facebook-auth