Closed potatojoayo closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0e8d308
) 96.77% compared to head (f4e3c13
) 96.77%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@potatojoayo thanks for your PR
Issue
389 [macOS] Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'dismissViewController:: Error: maybe this view controller was not presented?'
Cause
webView
function inFacebookAuthDesktopPlugin
class was callingdismiss(self)
. It threw the exception that the function was trying todismissViewController
which is not presented (or already closed; maybe it was being called twice).Solution
Instead of calling
dismiss(self)
, createdvar window: NSWindow?
and set self.view.window of the WebViewController as below.Then replace
dismiss(self)
withwindow?.performClose(nil)
inwebView
function.