search

darwin-on-arm / xnu

Porting the Darwin kernel to the AArch64/ARMv7/ARMv6-A architectures.
Other
583 stars 145 forks source link

double (useless) value parameter set, inside pe_omap3530.c. #3

Closed wargio closed 11 years ago

wargio commented 11 years ago

i know that this is not a real issue, but you have wrote this twice:

    OmapDispc->default_color0 = 0xffff0000;

    /* Initialize display control */
    OmapDispc->control |= DISPC_ENABLE;
    OmapDispc->default_color0 = 0xffff0000;

https://github.com/winocm/xnu/blob/master/pexpert/arm/pe_omap3530.c line 305 and 309..

winocm commented 11 years ago

Turns out, this is actually because of hardware initialization. It should be set twice anyway.