search

darwinex / dwx-zeromq-connector

Wrapper library for algorithmic trading in Python 3, providing DMA/STP access to Darwinex liquidity via a ZeroMQ-enabled MetaTrader Bridge EA.
https://blog.darwinex.com/zeromq-interface-python-r-metatrader4/
BSD 3-Clause "New" or "Revised" License
344 stars 228 forks source link

[ADMIN TODO] Rewrite for PEP8 Compliance #11

Open ommr101 opened 5 years ago

ommr101 commented 5 years ago

There are a few PEP8 violations in 'DWX_ZeroMQ_Connector_v2_0_1_RC8.py' file.

Such as:

image

There are two reasons it needs to be fixed (in my opinion):

  1. If I fixed it only on my end, each file update on the repository will overwrite my fix in case I would want to use the latest version.

  2. Almost all methods are named with a '_' as a prefix and Pycharm hides those methods as they are marked as private which is pretty uncomfortable.

Can I open a pull request and change this?

integracore2 commented 5 years ago

Hi @ommr101 ,

Yes, the code here was developed using our own internal standard, which isn't PEP8.

PEP8 is most certainly a good standard to follow, but we don't consider it a necessity that warrants updating the code at the present time. Also, there are a fair number of users currently using the project, and we wouldn't want to cause syntactical discrepancies by updating the current versions.

However, if you're interested in contributing a PEP8 compliant pull request for the project, that would be super kind of you and we'd give you full credit via our user and social channels! :)

If you do so, please create a copy of the contents of v2.0.2/ in a new directory within your fork called v2.0.2-PEP8, and make modifications there, prior to submitting your pull request.

Thanks!

integracore2 commented 5 years ago

HI @ommr101 ,

Happy to announce that for our next version, we are rewriting everything from scratch for PEP8 compliance 🙂

Stay tuned.

Prhmma commented 4 years ago

I will be more than happy to help with this issue.