Updated style - Githubissues

darwinex / dwx-zeromq-connector

Wrapper library for algorithmic trading in Python 3, providing DMA/STP access to Darwinex liquidity via a ZeroMQ-enabled MetaTrader Bridge EA.

https://blog.darwinex.com/zeromq-interface-python-r-metatrader4/

BSD 3-Clause "New" or "Revised" License

342 stars 227 forks source link

Updated style #91

Closed skyliquid22 closed 3 years ago

skyliquid22 commented 3 years ago

Description:

This PR offers an update to DWX_ZeroMQ_Connector_v2_0_1_RC8.py, below are the adjustments that have been made:

Fixed mutable arguments
Converted unwanted private functions to public
Converted unwanted private vars to public
Updated redundant conditional statement
Reformated file to follow pylint standards
Moved commented documentation to the docstring
Minor style improvements

Environment:

ipython v7 Python v3.7.7 Windows 10

elvinex commented 3 years ago

Hi, Thank you for your thoughts on improving the Code. The style may indeed not be optimal. However, changing parameter and function names could break existing code based on the current implementation. In addition, video tutorials refer to some of the parameters/functions, and changing the names would make it more difficult for beginners to follow the instructions. Therefore, we prefer to only included strictly necessary changes with regard to