chore: ring withdraw use dispatch precompiler

darwinia-network / apps

Darwinia Apps

https://apps.darwinia.network

1 stars 5 forks source link

chore: ring withdraw use dispatch precompiler #235

Closed JayJay1024 closed 2 years ago

github-actions[bot] commented 2 years ago

--- Commit: 2f773a5 Preview: https://apps-5r3nkwg5m-itering.vercel.app

--- Commit: aada39a Preview: https://apps-7ia36tjy9-itering.vercel.app --- Commit: 4907178 Preview: https://apps-a7htv9v4o-itering.vercel.app --- Commit: 74ad139 Preview: https://apps-4hbt6vvu2-itering.vercel.app --- Commit: 78a2243 Preview: https://apps-mdvbbfel1-itering.vercel.app --- Commit: ce7706b Preview: https://apps-ku74ql9jc-itering.vercel.app --- Commit: 90d7a9b Preview: https://apps-f816tkape-itering.vercel.app

hackfisher commented 2 years ago

@ZolaxZola Please help test.

~~And I think we need to add warn in the ui for the user, about the decimal of the balance is same with Crab chain, should be 9.~~

JayJay1024 commented 2 years ago

@ZolaxZola Please help test.

And I think we need to add warn in the ui for the user, about the decimal of the balance is same with Crab chain, should be 9.

Now here the precision is forced to 3.

hackfisher commented 2 years ago

Now here the precision is forced to 3.

Why introduce this design?

hackfisher commented 2 years ago

~And I think we need to add warn in the ui for the user, about the decimal of the balance is same with Crab chain, should be 9.~

Revoke this suggestion, use does need to care about this.

ZolaxZola commented 2 years ago

Now here the precision is forced to 3.

Why introduce this design?

may cause this problem：cannot transfer the 0.0005 CRAB part

ZolaxZola commented 2 years ago

From ：0x87F71162cAAC6D9fD8f48C2342509d838578CC81

hackfisher commented 2 years ago

Known issues:

Pre this pull request
- Users are sending values to 0x19 (not destination)
- 0x19 is unstable custom precompile
Post this pull request
- Users may not see values in metamask transferring, only calling to some contact 0x19 with un-readable calldata (looks dangerous)
- In apps, the apps will require to predict the gas fee, it is hard(gas price may change in metamask), so it make the apps hard to calculate how many balances are available for transfer. (Current solution, keep enough fees for gas cc @JayJay1024 )

hackfisher commented 2 years ago

@JayJay1024 @sxlwar We finally decide to use Dispatch compile, please continue with this PR, thanks.

Please take care of the consideration of UX challenges, leaving enough fees for user when the input amount, in case of confusions to users.