feat: estimated fee tips

darwinia-network / apps

Darwinia Apps

https://apps.darwinia.network

1 stars 5 forks source link

feat: estimated fee tips #323

Closed JayJay1024 closed 2 years ago

github-actions[bot] commented 2 years ago

--- Commit: 1ee483e Preview: https://apps-1v1i46j5n-itering.vercel.app

--- Commit: 4da03b4 Preview: https://apps-2rxlvh466-itering.vercel.app

ZolaxZola commented 2 years ago

Capitalized the first letter ofEstimated（Transferable ,too） Attention that the previous transferrable is typo.

JayJay1024 commented 2 years ago

Capitalized the first letter ofEstimated（Transferable ,too） Attention that the previous transferrable is typo.

Resolved, Transferable in #322

ZolaxZola commented 2 years ago

Fee Tips ofClaim Reward was supposed to be added

JayJay1024 commented 2 years ago

Fee Tips ofClaim Reward was supposed to be added

No, this is just the account selector, don't put this Fee Tips here

ZolaxZola commented 2 years ago

I'm not quite sure if it's an issue: when making a common transfer

[x] The amount from Fee tips on Darwinia Apps is always higher than on Polkadot apps
[ ] Fee amount from tips on Darwinia Apps seems to be the same while it always changes on Polkadot apps

ZolaxZola commented 2 years ago

Got it from Jay：The Estimate Fee on Darwinia Apps = 1.1* （fee on Polkadot Fee） In order to keep the same calculation as the transferrable.

ZolaxZola commented 2 years ago

I'm not quite sure if it's an issue: when making a common transfer

[x] The amount from Fee tips on Darwinia Apps is always higher than on Polkadot apps

[ ] Fee amount from tips on Darwinia Apps seems to be the same while it always changes on Polkadot apps

Can't reproduce this issue now(on polkadot apps fee changes while on Darwinia not). Let's work it out next time we meet this.