search

darwinia-network / bridger

Relayer client implementation for Darwinia LCMP protocols.
https://rust-docs.darwinia.network/bridger
GNU General Public License v3.0
11 stars 10 forks source link

bridger should not ignore the affirmed block #154

Closed xiaoch05 closed 3 years ago

xiaoch05 commented 3 years ago

[2021-02-01T13:03:04Z TRACE darwinia_bridger::service::subscribe] >> Event - EthereumRelay::Affirmed

[2021-02-01T13:03:27Z INFO darwinia_bridger::service::extrinsics] Affirmed ethereum block 9578895 in extrinsic 0x6ded1200c2e7cf49891c7e1581a7e8c4ce80baf0a5aba689897d660a2487722c

bridger found affirmed block 9578895 by Event EthereumRelay::Affirmed which created by extrinsic https://crab.subscan.io/extrinsic/0x06e26aba1a3b2218e859a611ffecca93128d080f230460505708e501c4025658

but it ignored and also create a failed extrinsic https://crab.subscan.io/extrinsic/0x6ded1200c2e7cf49891c7e1581a7e8c4ce80baf0a5aba689897d660a2487722c

wuminzhe commented 3 years ago

relate to #24

It has been checked before sending. The affirming parcel in special status may not be checked

hackfisher commented 3 years ago

The fundamental solution for this would be validate signed in extrinsic pool in nodes & network side, because the affirm can still fail if there are no events, two affirm goes into extrinsic pool at the same time.

https://github.com/darwinia-network/darwinia-common/issues/669