darwinia-network / darwinia-2.0

Preparation for Darwinia 2.0
5 stars 1 forks source link

Use Parity `pallet-balances` #8

Closed AurevoirXavier closed 1 year ago

AurevoirXavier commented 2 years ago

Why we use custom balances: https://github.com/darwinia-network/darwinia/issues/65

We spend too much extra time on this. But the only advantage is that no need to withdraw after unbond. And we have to maintain all the pallets which used LockableCurrency. Also, all the mocks need to be changed to use Account.

Furthermore, we can still add an ExtraLock to tracking the unbonding timestamp in darwinia-staking, which could also meet the current requirements.

boundless-forest commented 2 years ago

I am extremely excited about this code optimization and if it can be implemented.

hackfisher commented 2 years ago

There are some account which have staking can not show their balances on https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.darwinia.network#/accounts

Might be able to be fixed together with this issue. cc @1022ranji @sxlwar

AurevoirXavier commented 2 years ago

There are some account which have staking can not show their balances on https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.darwinia.network#/accounts

Might be able to be fixed together with this issue. cc @1022ranji @sxlwar

All my stakers display correctly.

AurevoirXavier commented 2 years ago

There are some account which have staking can not show their balances on https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.darwinia.network#/accounts

Might be able to be fixed together with this issue. cc @1022ranji @sxlwar

darwinia-network/darwinia-common#840 cc @sxlwar

AurevoirXavier commented 2 years ago

Note:

hackfisher commented 2 years ago

I added this to kanban and maybe good to have it before darwinia-network/darwinia-common#1055 .

AurevoirXavier commented 2 years ago

Blocked by

AurevoirXavier commented 1 year ago

12.