search

darwinia-network / darwinia-common

Darwinia Runtime Pallet Library and Pangolin/Pangoro Testnet
https://rust-docs.darwinia.network/darwinia-common
GNU General Public License v3.0
30 stars 9 forks source link

match against the pallet's index instead of Instance index? #1172

Closed hackfisher closed 2 years ago

hackfisher commented 2 years ago

Acceptable but maybe better to match against the pallet's index instead of Instance index?

Instance index is part the implementation instead of interface, and should not be exposed?

FeeMarket is Instance1 (0 =>...), WithParachainFeeMarket is Instance2 (1 =>...), as a result the instance concept is also changed here, working as another concept for rpc interface.

_Originally posted by @HackFisher in https://github.com/darwinia-network/darwinia-common/pull/1171#discussion_r848114465_

hackfisher commented 2 years ago

And also need to ask the opinions of apps developers, @JayJay1024

If they think the SDK approach is better, these rpc can also be removed and deprecated.

SDK derive api feature request: https://github.com/darwinia-network/darwinia.js/issues/63

JayJay1024 commented 2 years ago

And also need to ask the opinions of apps developers, @JayJay1024

If they think the SDK approach is better, these rpc can also be removed and deprecated.

SDK derive api feature request: darwinia-network/darwinia.js#63

yeah, the way through the sdk is better

AurevoirXavier commented 2 years ago

All custom RPC removed.