S2S SDK - Githubissues

darwinia-network / darwinia-messages-sol

Darwinia cross-chain messages gateway and protocol for EVM developers 💌

MIT License

29 stars 8 forks source link

S2S SDK #158

Closed wuminzhe closed 2 years ago

wuminzhe commented 2 years ago

[x] market_fee. https://github.com/darwinia-network/darwinia-common/issues/1198
[x] send message
[x] confirmed callback. https://github.com/darwinia-network/darwinia-bridges-sol/issues/157

hackfisher commented 2 years ago

Please merge master, fix conflicts and CI.

hackfisher commented 2 years ago

@hujw77 Please help review

wuminzhe commented 2 years ago

yes, but there is no standalone market fee precompile.

xiaoch05 commented 2 years ago

LGTM, only one thing is not elegant. Fetch market_fee from storage_state is not clean, need to extra scale decode and eliminate irrelevant info.

Can we just get the storage of the fee? @wuminzhe

wuminzhe commented 2 years ago

LGTM, only one thing is not elegant. Fetch market_fee from storage_state is not clean, need to extra scale decode and eliminate irrelevant info.

Can we just get the storage of the fee? @wuminzhe

Yes, the fee is obtained from storage.