search

darwinia-network / darwinia-messages-sol

Darwinia cross-chain messages gateway and protocol for EVM developers 💌
MIT License
29 stars 8 forks source link

`MAX_PENDING_MESSAGES` might not be approximate #92

Closed hackfisher closed 1 year ago

hackfisher commented 2 years ago

MAX_PENDING_MESSAGES might not be approximate here, since it it only storing message data, and we can limit buffer using MAX_UNCONFIRMED_MESSAGES when delivering messages on target chain(relayers will help handle this.).

Beside, the side effect is it will limit the usage from client, and cause bad UX.

Originally posted by @HackFisher in https://github.com/darwinia-network/darwinia-bridge-sol/pull/77#r753075550

hujw77 commented 1 year ago

At serial channel, the proof needs all leaves/messages. MAX_PENDING_MESSAGES is necessary now. At parallel channel, there is no limit such as MAX_PENDING_MESSAGES, MAX_CALLDATA_LENGTH etc...