search

darwinia-network / darwinia-offchain-tools

Ethereum bridge relayer tools
3 stars 4 forks source link

Refactoring the code and clean the logic. #6

Closed hackfisher closed 4 years ago

hackfisher commented 4 years ago

Some duplicate codes and logics found.

For example:

finalizedBlockNumber: parseInt(this.finalizedBlockNumber.toString()), // - (this.killedNumber % 2)
finalizedBlockNumber: parseInt(this.finalizedBlockNumber.toString()) - (this.killedNumber % 2),

and 

let hasResetGenesisHeader = false;
            if (!Config_1.default.hasResetGenesisHeader) {
                logger_1.default.info("start build resetGenesisHeader extrinsic");
                ex = api.tx.ethRelay.resetGenesisHeader(header, block.totalDifficulty);
                hasResetGenesisHeader = true;
            }
WoeOm commented 4 years ago

IDE provides automatic compilation function leading to duplicate codes and logics