Update dependance for pangolin network in polkadot official repo

darwinia-network / darwinia.js-1.0-deprecated

Javascript API and Types

Apache License 2.0

5 stars 4 forks source link

Update dependance for pangolin network in polkadot official repo #7

Closed sxlwar closed 3 years ago

sxlwar commented 3 years ago

repo: https://github.com/polkadot-js/apps

path: packages/app-config

dep: @darwinia/types

AurevoirXavier commented 3 years ago

These types are a part of s2s. They are common types.

I don't know if it's good to place them in darwinia types.

hackfisher commented 3 years ago

@fewensa If these types are from parity-bridge-common, which is also third-party to substrate&polkadot.js, maybe we should put it simply in darwinia types since polkadot.js will not automatically handle it.

parity-bridge-common can maintain a type.json file for darwinia types as a reference.

sxlwar commented 3 years ago

fixed by this pr

I will close this issue, anything else to discuss pls reopen it or create another issue.