darwinia-network / darwinia

Darwinia Chain, EVM+, Polkadot parachain and integrating with XCMP.
https://darwinia.network
GNU General Public License v3.0
239 stars 49 forks source link

The `try-runtime` and the `runtime-benchmarks` cannot be used simultaneously. #1246

Closed AurevoirXavier closed 1 month ago

AurevoirXavier commented 1 year ago

https://github.com/darwinia-network/darwinia/blob/336c98af839cacbc1163acc030b776f1edcfa6b1/runtime/darwinia/src/lib.rs#L95-L106

AurevoirXavier commented 1 year ago

@boundless-forest do you remember why we need this runtime version patch for benchmarking?

boundless-forest commented 1 year ago

https://github.com/darwinia-network/darwinia/pull/1158

To make the benchmark call dispatch successful, the spec_version required to be the same as the hard-coded one in the messsage benchmark script. So introduced another VERSION under benchmark feature.