search

darwinia-network / dj

Darwinia bridge relayer tool implemented in nodejs
GNU General Public License v3.0
4 stars 5 forks source link

Member of first proposal should not be itself #57

Closed wuminzhe closed 4 years ago

wuminzhe commented 4 years ago

https://github.com/darwinia-network/darwinia.js/blob/e93b3dd0c44f0d3507234a995c7108432889cdaf/packages/dj/src/proposal.ts#L118

recommended to use last confirm block: const target = await shadow.getProposal([last_confirm_block], block);

clearloop commented 4 years ago

recommended to use last confirm block: const target = await shadow.getProposal([last_confirm_block], block);

The liner relayer which is deprecated needs the last_confirm_block, the current relayer, we just relay.

AurevoirXavier commented 4 years ago

You should make sure the mmr root include last confirmed's mmr hash.

And this's a bug of ethereum-relay which miss the first mmr's verification.

https://github.com/darwinia-network/darwinia-common/issues/252

clearloop commented 4 years ago

You should make sure the mmr root include last confirmed's mmr hash. darwinia-network/darwinia-common#252

So the uncle 19 has to be deleted now? LOL

AurevoirXavier commented 4 years ago

So the uncle 19 has to be deleted now? LOL

Yes, on proposal.