search

darwinia-network / dj

Darwinia bridge relayer tool implemented in nodejs
GNU General Public License v3.0
4 stars 5 forks source link

Meaning of these magic numbers? #66

Open hackfisher opened 3 years ago

hackfisher commented 3 years ago

https://github.com/darwinia-network/dj/pull/63#pullrequestreview-481466507

hackfisher commented 3 years ago

Update: https://github.com/darwinia-network/dj/blob/master/src/api/darwinia.ts#L216

clearloop commented 3 years ago

Update: https://github.com/darwinia-network/dj/blob/master/src/api/darwinia.ts#L216

https://github.com/darwinia-network/dj/blob/74cfb7f77a656f7800b3d6d39d0ae5c07d7fd04e/src/api/darwinia.ts#L202-L216

freehere107 commented 3 years ago

@clearloop Maybe use enum or const to replace code comment will be better

clearloop commented 3 years ago

@clearloop Maybe use enum or const to replace code comment will be better

Later after the bridger, it will be finished tonight.