search

darwinia-network / home

https://darwinia.network/#/about
https://darwinia.network
4 stars 6 forks source link

Feat new version #309

Closed isunaslabs closed 2 years ago

isunaslabs commented 2 years ago

Branch renamed from feat-new-code to feat-new-version The overall code is still under development NOTE: 1.Typewriter effect on the hero component on every page is not added yet 2.Animation on the code sample view on the home page is not added yet

github-actions[bot] commented 2 years ago

--- Commit: f6d4d11 Preview: https://home-c79c0s6t5-itering.vercel.app

--- Commit: c3b91fb Preview: https://home-me3qco7f3-itering.vercel.app --- Commit: 966b9aa Preview: https://home-6amfjztoy-itering.vercel.app --- Commit: da1c309 Preview: https://home-1tynokhhp-itering.vercel.app --- Commit: 5533978 Preview: https://home-2hy9u2psf-itering.vercel.app --- Commit: 20eef4b Preview: https://home-80t5ejpb6-itering.vercel.app --- Commit: b831d5e Preview: https://home-gu2k8hw9q-itering.vercel.app --- Commit: 4eca8d6 Preview: https://home-oh9ds7i9k-itering.vercel.app --- Commit: 05990e9 Preview: https://home-b31vw04pv-itering.vercel.app --- Commit: 41673b1 Preview: https://home-mb63ei7nz-itering.vercel.app --- Commit: 06c04cf Preview: https://home-156uac84v-itering.vercel.app --- Commit: fe0c6b2 Preview: https://home-4ldgjcbgw-itering.vercel.app --- Commit: 02c4a18 Preview: https://home-6du3t5yxy-itering.vercel.app --- Commit: 10c8896 Preview: https://home-j3iha3he2-itering.vercel.app --- Commit: e0172d5 Preview: https://home-mo1t4oamt-itering.vercel.app --- Commit: 57e27a1 Preview: https://home-b23my8fog-itering.vercel.app

JayJay1024 commented 2 years ago

LGTM

fewensa commented 2 years ago

It looks like you used hash-style route, you can delete it. add it if you use history-style route (and update the right uri path). @isunaslabs

https://github.com/darwinia-network/home/blob/10c8896454388de2cda032da7ca16ecd4d6224ec/vercel.json#L26-L39

fewensa commented 2 years ago

Maybe this file/folder is not required? 🤔 https://github.com/darwinia-network/home/blob/10c8896454388de2cda032da7ca16ecd4d6224ec/.vscode/settings.json#L1

isunaslabs commented 2 years ago

Maybe this file/folder is not required? 🤔

https://github.com/darwinia-network/home/blob/10c8896454388de2cda032da7ca16ecd4d6224ec/.vscode/settings.json#L1

I understand. I'll delete that directory. Thanks for the feedback

isunaslabs commented 2 years ago

Yeah! I noticed that the data in it maybe useless since I'm using the hash router but I left it just for the future reference.