darwinye / tab-organizer

Automatically exported from code.google.com/p/tab-organizer
Other
0 stars 0 forks source link

Tab Organizer stopped working in recent chromium builds #130

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download a build from http://build.chromium.org/f/chromium/continuous/LATEST/
2. Install Tab Organizer
3. Click the action button

What is the expected output? What do you see instead?
It opens and shows all open tabs. It's empty.

What version of the product are you using? On what operating system?
Chromium 10.0.652.0. Tab Organizer - Version: 3.6. Windows 7.

Please provide any additional information below.
This is the error in console:
UI%20Helper.js:51    Uncaught SyntaxError: Octal literals are not allowed in 
strict mode.

There were changes to v8 related to strict mode and now Chrome correctly 
doesn't allow octal escape sequences like "\0". Changing it to "\x00" should 
fix it.

Original issue reported on code.google.com by temp01...@gmail.com on 28 Jan 2011 at 10:05

GoogleCodeExporter commented 9 years ago
Isn't \0 supposed to be null? I'm using that as a trick to make the tooltip 
popup NOT appear. Setting title to "" doesn't work. Using spaces doesn't work. 
But using \0 does. I'll try \x00 and see if that still has the desired effect.

Original comment by pcxunlimited@gmail.com on 28 Jan 2011 at 7:56

GoogleCodeExporter commented 9 years ago
Alright, I changed \0 to \x00.

("\0" === "\x00") is true, so I don't think it'll cause any problems.

This is important enough to make another release. Thanks for the good report.

Original comment by pcxunlimited@gmail.com on 28 Jan 2011 at 8:01

GoogleCodeExporter commented 9 years ago
I just pushed out version 3.6.5. Please tell me if this bug is still occurring 
with that version or not.

Original comment by pcxunlimited@gmail.com on 28 Jan 2011 at 8:08

GoogleCodeExporter commented 9 years ago
Works fine now (after updating to v3.6.5). Thanks for the quick update.

Original comment by temp01...@gmail.com on 29 Jan 2011 at 12:58

GoogleCodeExporter commented 9 years ago
Good, good. Seems a little weird that null would be counted as an octal escape. 
Either way, I'm glad that the fix was easy.

Original comment by pcxunlimited@gmail.com on 29 Jan 2011 at 9:18

GoogleCodeExporter commented 9 years ago
After your comment, I checked FF4 and noticed that it allows \0 in strict mode. 
So I filed an issue for v8 (issue v8:1084) after confirming in #v8 channel.

Original comment by temp01...@gmail.com on 29 Jan 2011 at 11:49

GoogleCodeExporter commented 9 years ago

Original comment by pcxunlimited@gmail.com on 27 Aug 2012 at 11:44