darwinye / tab-organizer

Automatically exported from code.google.com/p/tab-organizer
Other
0 stars 0 forks source link

Tab Organizer broken in recent Chromium build (strict mode error) #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open Tab Organizer or try to open the Options page
2.
3.

What is the expected output? What do you see instead?
It should work and show the open tabs. But instead, both pages are blank.

What version of the product are you using? On what operating system?
Tab Organizer 3.8. Chromium 11.0.698.0 (77555). Windows 7.

Please provide any additional information below.

The function definition inside the if(){} block in "UI Helper.js" on line 157 
is invalid in strict mode. Chrome throws an "Uncaught SyntaxError: In strict 
mode code, functions can only be declared at top level or immediately within 
another function. - UI%20Helper.js:157" error. See the screenshot.

Original issue reported on code.google.com by temp01...@gmail.com on 10 Mar 2011 at 7:47

Attachments:

GoogleCodeExporter commented 9 years ago
Uh, my bad. The broken extension was actually a locally loaded Tab organizer 
from some time ago (v 3.3) which somehow got enabled. So I had two versions of 
Tab Organizer running side by side and didn't notice. v3.8 is working just fine 
- this issue can be closed.

Original comment by temp01...@gmail.com on 11 Mar 2011 at 6:05

GoogleCodeExporter commented 9 years ago
Oooh, right, I had one of those errors, but in a different area. Interesting 
that strict mode disables that. I think it's a good thing overall, though. I 
mostly try not to write function blocks within if statements, but occasionally 
it happens.

Original comment by pcxunlimited@gmail.com on 18 Mar 2011 at 12:43

GoogleCodeExporter commented 9 years ago

Original comment by pcxunlimited@gmail.com on 27 Aug 2012 at 11:44