darxkies / k8s-tew

Kubernetes - The Easier Way
GNU General Public License v3.0
307 stars 38 forks source link

Kill processes on node during deploy #17

Closed figassis closed 3 years ago

figassis commented 5 years ago

Whenever a deploy fails and a change requires me to run generate, I have to deploy with --force-upload. But if a file on the node is already locked by a process (eg. containerd-shim), then the deployment fails. It would be nice as a preparation to kill these processes before deploying on a node.

darxkies commented 5 years ago

Can you give some examples of files that are locked? Some log messages would be very helpful.

figassis commented 5 years ago

I don't have then anymore, but I struggled with containerd-shim, because it was always running when I tried to redeploy

darxkies commented 5 years ago

I did not have any issues like that. Which distribution did you use to install it to?

figassis commented 5 years ago

I installed k8s-tew on ubuntu 18.04 inside vagrant, and deployed on a clean remote machine, also ubuntu 18.04. I would have to ssh into the node and kill it or even delete it there sometimes

darxkies commented 5 years ago

Was it by any chance 18.04.3 and kernel 5.0?

figassis commented 5 years ago

Ubuntu 18.04.2 LTS Kernel 4.15.0-52-generic

darxkies commented 5 years ago

I was able to reproduce it. In previous k8s-tew releases, all containers and processes on a node were killed before upgrading. I will enable it with the next release.

darxkies commented 3 years ago

When stopping k8s-tew all processes get killed.