search

darxtrix / ptop

An awesome task manager written in python. :computer:
http://darxtrix.in/ptop/
MIT License
576 stars 43 forks source link

Fixes #22 [ Custom refresh rates for different sensors ] #46

Closed vinusankars closed 6 years ago

vinusankars commented 6 years ago

Refresh rates are input by the user using argparse. The GUI gets the refresh rates for sensor and uses it to update the sensor rates.

darxtrix commented 6 years ago

Looks good, we might need to add a .ptoprc file saving the default configuration for ptop invocation so that the user don't require to pass them each time while starting ptop.

vinusankars commented 6 years ago

@darxtrix can you please make me a main contributor? I will try incorporating a config file for keyboard shortcuts too!

darxtrix commented 6 years ago

Sure, but I would like to take a little time before that. We have to define and streamline the PR body/heading format and the commit messages format also.

darxtrix commented 6 years ago

@vinusankars great work. Will merge them tomorrow. I think we are good for 1.0 version release after this. Can we skip adding new features for a day or two and focus more on thorough testing. One important feature we need to add before realising is of auto update because there is no way of knowing which users are using old version of ptop and subsequently the new users will be able to get ptop updates afterwards. For now we will put up a blog and email the stargazers and contributors about it. Let me know if you have any other ideas.

vinusankars commented 6 years ago

@darxtrix We can try to deb package ptop 1.0 too, in the coming days. (apt-get)

darxtrix commented 6 years ago

@vinusankars Absolutely, there is an issue tracking this feature https://github.com/darxtrix/ptop/issues/23. Additionally we can have a brew tap also. I remember someone created an aur package for arch based systems, it have to be updated now. Let's finalize a date for the release ?

vinusankars commented 6 years ago

@darxtrix What about tomorrow?

darxtrix commented 6 years ago

No that will be too soon. Need to test ptop well before that. I am using the updated ptop on daily basis for the task managing task now. Lets setup a session of 30 mins on sometime Friday and test ptop in different scenarios and take a buffer day to fix issues if there are some. I will write changelog and a blog on Sunday. Then we can go live on next Monday ?

vinusankars commented 6 years ago

Sure @darxtrix . @deeps-nars please see the above comments. Let us do this.

darxtrix commented 6 years ago

@vinusankars @deeps-nars You guys please join gitter. Have invited you. Its better to keep track of meaningful conversations over there otherwise we will have to lurk through all the issues/PRs for finding comments :sweat_smile:

darxtrix commented 6 years ago

Merged with some code refactoring, great work @vinusankars !