Rename Queryable::execute()

darya / framework

PHP Web Application Framework

http://darya.io/

MIT License

2 stars 1 forks source link

Rename Queryable::execute() #51

Closed hexus closed 7 years ago

hexus commented 7 years ago

It sounds like... :boom: :gun:

Queryable::query() is already taken for opening a new query builder. That's also how query() methods are used everywhere else in the API, so for consistency I don't feel like changing that.

Alternatives:

->fetch()
->send()
->run()
->get()

hexus commented 7 years ago

Decided to go with run() because it's quite semantic:

$storage->run($query);

hexus commented 7 years ago

Also renamed Query\Builder::execute(). Splendid.