search

darylldoyle / svg-sanitizer

A PHP SVG/XML Sanitizer
GNU General Public License v2.0
456 stars 68 forks source link

Improve remote reference detection #15

Closed SeinopSys closed 6 years ago

SeinopSys commented 6 years ago

This change aims to address some shortcomings of the current remote reference checking method that allows //example.com/folder or ftp://… links to go through for example. I'm more confident using this sanitizer in my project with these changes.

Tried to follow the formatting of the file, but if something's off with that or the way this was done please let me know.

silbinarywolf commented 6 years ago

@darylldoyle Are you able to get this in?

darylldoyle commented 6 years ago

Hey, sorry hectic few weeks.

Change looks good and tests passing nicely. Will merge now, thank you :)

SeinopSys commented 6 years ago

@darylldoyle I'd like to ask for a release with this fix - when your time allows - so that it can be obtainable for everyone using the library & I could remove the repository block pointing to my fork from my project's composer.json.

darylldoyle commented 6 years ago

Apologies @SeinopSys, I could have sworn I tagged the release, turns out I forgot to push the tag up.

0.7.2 now includes this change. Thanks again for the PR!