search

darylldoyle / svg-sanitizer

A PHP SVG/XML Sanitizer
GNU General Public License v2.0
456 stars 68 forks source link

Question: why not to use kses? #23

Closed markkap closed 5 years ago

markkap commented 5 years ago

Any reason why in the context of WordPress this library do not use KSES? Is it just to keep it portable or are there any other reasons?

(very shallow inspection of the code reveals functionality with is very similar to what kses does)

darylldoyle commented 5 years ago

Hi @markkap, the main reason to not use KSES is that this library is standalone from WordPress and therefore can be used in other PHP projects. This enables a larger proportion of the PHP community to contribute and test the library.

There was also a discussion around KSES in the initial WordPress core ticket https://core.trac.wordpress.org/ticket/24251#comment:73.

markkap commented 5 years ago

Thanks

On Thu, Jan 3, 2019 at 3:02 PM Daryll Doyle notifications@github.com wrote:

Hi @markkap https://github.com/markkap, the main reason to not use KSES is that this library is standalone from WordPress and therefore can be used in other PHP projects. This enables a larger proportion of the PHP community to contribute and test the library.

There was also a discussion around KSES in the initial WordPress core ticket https://core.trac.wordpress.org/ticket/24251#comment:73.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/darylldoyle/svg-sanitizer/issues/23#issuecomment-451136757, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJnmsH_fnsrj04uK2n35pkgtdemjj_Aks5u_f9mgaJpZM4ZgKQX .