search

darylldoyle / svg-sanitizer

A PHP SVG/XML Sanitizer
GNU General Public License v2.0
465 stars 68 forks source link

Allow empty href values #42

Closed abarkine closed 3 years ago

abarkine commented 4 years ago

Both DOMElement::getAttributeNS and DOMElement::getAttribute returns empty strings if no attribute with given name found. This is causing faulty return values in Sanitizer::getXmlIssues method.

Fixes #39

spacedmonkey commented 3 years ago

@darylldoyle Any chance this could be merged? It fixes an issue for my implementation.

darylldoyle commented 3 years ago

Thanks for getting this in @asilelik. sorry about the delay!