search

darylrowland / angucomplete

AngularJS Autocomplete Directive
510 stars 281 forks source link

Revert extractValue function so that it allows users to specify an arbit... #20

Closed ghiden closed 10 years ago

ghiden commented 10 years ago

https://github.com/ghiden/angucomplete/commit/b225cb2f900f43cf0ddf65545f031536c1d0a1a7 As stevenharman pointed out, my last attempt to remove all eval broke some people's code. So I revert the extractValue function back. I added some tests so that if someone tries to refactor it, these tests should pass too.

stevenharman commented 10 years ago

Can we get this back in - or at least the specs so we can get a better solution? It's been a while and things are rapidly getting stale.

ghiden commented 10 years ago

@stevenharman I've taken this change to my fork, angucomplete-alt (https://github.com/ghiden/angucomplete-alt). It's a bit different from the original but if you have time, please give it a try.

stevenharman commented 10 years ago

Thanks for the update. It would be nice to get angucomplete itself working again, but given the number of outstanding issues and Pull Requests, it looks like the project might be in trouble.

ghiden commented 10 years ago

Addressed in #43