search

darylrowland / react-native-remote-push

React Native Remote Push Notifications Component
MIT License
158 stars 29 forks source link

Provide an xcode project with a library target #11

Open isair opened 9 years ago

isair commented 9 years ago

Most react-native npm packages do this; eases and standardizes the installation process. Some examples: react-native-video, react-native-linear-gradient, react-native-activity-view.

ghost commented 8 years ago

+1 for including the .xcodeproj file in the release

darylrowland commented 8 years ago

I'll have a look at this when I get a chance. In the meantime if anyone wants to submit a pull request to fix this please feel free :)

ghost commented 8 years ago

@brentvatne know of any articles for generating the Xcodeproj file using something like what CocoaPods uses, or even a manual method with steps boiled down for RN library authors? Thanks in advance.

brentvatne commented 8 years ago

I do not @jhabdas! I have always just created a project from scratch in Xcode and then added the react-native dependency manually

ghost commented 8 years ago

So that's the trick! :P

darylrowland commented 8 years ago

I've published this change to NPM now. The only issue is that the project file doesn't seem to include RemotePushDelegate.m and RemotePushDelegate.h - so these need to be added manually to the project. I'll update the instructions when I get round to it.

Thanks everyone!

ghost commented 8 years ago

You the man @darylrowland! Hope the community bands together to make a generator of some kind as time goes on so a tool can come along and automate module generation and consumption.

darylrowland commented 8 years ago

I think I saw something called rnpm for react native modules the other day. Will take a look when I get a chance. Or if anyone else knows about it, feel free to make a pull request.

On 16 Dec 2015, at 00:52, Josh Habdas notifications@github.com wrote:

You the man @darylrowland! Hope the community bands together to make a generator of some kind as time goes on so a tool can come along and automate module generation and consumption.

— Reply to this email directly or view it on GitHub.