search

daryltay415 / pe

0 stars 0 forks source link

Saving bouquet names with "<" or ">" will crash the app #5

Open daryltay415 opened 5 months ago

daryltay415 commented 5 months ago

image.png

When saving the bouquet into a test file, it does not handle the case whereby there would be "<" or ">" characters in the name. Even though this a medium severity bug, it could be a high severity bug as users could accidently input the wrong characters "<" when typing fast. This could lead to them crashing the app unexpectedly

soc-pe-bot commented 5 months ago

Team's Response

Not accepting those special characters when creating bouquet names would solve this issue, hence its a duplicate of that issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect acceptance of special characters <>

Expected behaviour: User input should be rejected if user inputs special characters such as <>/\ as alphabets should only be accepted for bouquet names Actual behaviour: user input of special characters is accepted

image.png

[original: nus-cs2113-AY2324S2/pe-interim#321] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is intended that special characters can be used for bouquet name for more flexibility in naming for the users.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The original issue mentioned that the app allows bouquets with special characters in their name. However my issue is focused on how the app is unable to save special characters.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** It should be a feature flaw as the saving is actually not handled properly since it crashes the app when trying to save a character.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** In the original issue, the team responded that the bouquet allows special characters. However, inputting special characters will cause the program to crash. In addition, users can easily mistype and add special characters if they were typing too fast. Hence, the flaw would cause occasional inconvenience to some users. Thus, the severity should be medium at least.