search

das-developers / das2java

The original das2 library. Provides interactive publication-ready 2-D plotting
https://das2.org
GNU Lesser General Public License v3.0
4 stars 0 forks source link

series render data reduction can make all data invalid #12

Closed jbfaden closed 3 years ago

jbfaden commented 3 years ago

Ivar has a case where the data has a VALID_MAX of 1.0, and most of the data is at 0.999 or 1.0. When plotting with the series renderer, the data triggers the reduce branch, since there are many points. The reduce branch looks at the axes, and then reduces the data. However, this has the effect of slightly changing the reduced values, to a point where the bin is above 1.0 and they are all marked as invalid.

jbfaden commented 3 years ago

This has the unusual effect of being position-dependent. See the animated gif attached. pngwalk

jbfaden commented 3 years ago

The problem the Reduction.histogram2D was used to find a reduced set, but then the old valid range was used on the reduced set. This is fixed. However, a better version of reduce data set should actually do the whole operation one and correctly.