das-developers / das2java

The original das2 library. Provides interactive publication-ready 2-D plotting
https://das2.org
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Consider logic true tables when fill data is used #36

Open jbfaden opened 1 year ago

jbfaden commented 1 year ago

Ivar and I ran into a difficult bug to diagnose when we has the expression:

ds.lt(100).or(valid(ds).eq(False))

The problem is that where ds is not valid, the "or" result would also be invalid, making the logic be incorrect.

We should consider whether (True.or(Fill)) should be True, since the or has a True argument. The impact on all operators, making sure that rules like commutativity follow.