search

das-developers / das2java

The original das2 library. Provides interactive publication-ready 2-D plotting
https://das2.org
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Two small fixes in org.das2.graph #54

Closed DiamondJim87 closed 1 year ago

DiamondJim87 commented 1 year ago

Note: adding this issue after I checked in the fixes.

Yesterday (2023-04-03) I checked in a small improvement to GraphUtil.copyPlot. This method is used to create a duplicate of a given plot that looks and acts like the original plot. Creating the copy involves also copying all the Renderers. The change was, when copying SeriesRenderer instances, to copy the isCadenceCheck switch, which is an important property for behavior and performance of the plot.

Today (2023-04-04) I checked in a bug fix to the DataRange.removePropertyListener method. The body of the method was clearly just copied and pasted from the DataRange.addPropertyListener method, so in fact, the remove method was doing the same thing as add. For me this manifested as a bug that when one called DasAxis.detach, the axis would only partially detach from its head axis.

DiamondJim87 commented 1 year ago

As noted in the issue text, this was already resolved before opening this issue.

DiamondJim87 = James Peachey, James.Peachey@jhuapl.edu.