das-developers / das2java

The original das2 library. Provides interactive publication-ready 2-D plotting
https://das2.org
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Make DasAxis.getAxisBounds() method public? #77

Closed DiamondJim87 closed 10 months ago

DiamondJim87 commented 10 months ago

This method currently is protected, but it would be useful for my custom layout code to be able to know how much space the axis will take up. Is there any downside to making this method public? If not, I can quickly enough make/push this change.

jbfaden commented 10 months ago

I think that's fine.

DiamondJim87 commented 10 months ago

Just tested and committed this change. The space is computed correctly, but there's a new problem which I'll file in a separate issue.