das-labor / panopticon

A libre cross-platform disassembler.
https://panopticon.re
GNU General Public License v3.0
1.43k stars 78 forks source link

Standardize formatting using rustfmt #267

Open sphinxc0re opened 7 years ago

flanfly commented 7 years ago

I see the advantage of an coding style, but this needs to be checked for automatically. I do not want reviewers to waste their time checking correct brace placement, that's what machines are for. If we have a bot that checks to coding style for every PR, that would be acceptable, but if this is a manual process I'd rather have no coding style at all. In case we decide we want a coding style we must document it w/ instructions on how to format the code.

sphinxc0re commented 7 years ago

I'm already doing that at rpg-rs

sphinxc0re commented 7 years ago

It is automatically checking the code and returning errors

sphinxc0re commented 7 years ago

The problem is, that currently, a lot of the current code would fail regardless of formatting using rustfmt because some code lines are simply too long to format automatically

sphinxc0re commented 7 years ago

The question here is: Do we care about line lengths? If not, we can just configure rustfmt to consider a longer line length