Closed flanfly closed 7 years ago
I consider it done now. I'll keep the PR open for 3-4 days in case anybody wants to review it.
This looks awesome!
So loading up tests/data/libfoo.so
, clicking on most of the functions yields this error and does not display anything:
qml: display cfg for 765fa2cb-dea2-42de-8309-2ae43e00bf4f
ERROR:qtpanopticon::singleton: layouting failed
also, what happened to the function names, as they're no longer reported and just shows func_<address>
, etc. See screenshot
Some other things:
__phi
in the disassembly)__init
at the top of the cfgERROR:qtpanopticon::singleton: layouting failed
You're right :/
Seems many of issues above are gone/fixed now, awesome work!
However, building and running on libfoo.so
and clicking on ifoo
function causes crash:
cargo run tests/data/libfoo.so
Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
Running `target/debug/qtpanopticon tests/data/libfoo.so`
qml: display cfg for 33120385-c5dc-4bdc-934d-cabf89db3aa7
ERROR:qtpanopticon::glue: send_function_nodes(): Input graph is empty
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Panopticon(Error("Input graph is empty")), State { next_error: None, backtrace: None })', /buildslave/rust-buildbot/slave/stable-dist-rustc-linux/build/src/libcore/result.rs:868
note: Run with `RUST_BACKTRACE=1` for a backtrace.
fatal runtime error: failed to initiate panic, error 5
Yep, some functions crash the layout algorithm. Shouldn't be too hard to fix.
Somebody review this shit.
Thanks everybody!
Coverage increased (+0.2%) to 60.996% when pulling 6160559737af59f0c7660c75137c47b1e54746a4 on flanfly:frontend into 31304534f6429bc787ed955de237d05a46146958 on das-labor:master.