das-labor / panopticon

A libre cross-platform disassembler.
https://panopticon.re
GNU General Public License v3.0
1.43k stars 78 forks source link

Reorganize project & formatting #295

Closed flanfly closed 7 years ago

flanfly commented 7 years ago

fixes #258

flanfly commented 7 years ago

It's a dirty job but somebody has to do it.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-44.7%) to 12.973% when pulling f70d20e739453693173271759d85b2fc839274fa on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.3%) to 56.459% when pulling d41d44661db30858faf906bc5e4e23c5e6059990 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

m4b commented 7 years ago

How come abstract interpretation is its own crate ?

flanfly commented 7 years ago

Well, in theory you don't need it. For example disassembling an AVR dump only needs core & avr. Edit: Also, when I start with the decompiler I'll need to implement two additional abstract domains. I expect that to be another 3k loc.

m4b commented 7 years ago

Ah k. So lib/src is gone now right ? That always bothered me :)

flanfly commented 7 years ago

Yes, most of the lib is now in core.

m4b commented 7 years ago

Sweet! I just meant the extra directory of lib, then src

flanfly commented 7 years ago

In case there aren't any objections I'll pull the trigger tomorrow.

m4b commented 7 years ago

one side of effect of this is compile time will drop when hacking on a submodule :+1:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.7%) to 60.435% when pulling 1791babe01edc1dd2caa686ebe446ac4f673c150 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.6%) to 60.286% when pulling a8942dc14d08516afea94edd79c41f39328fe3d1 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.8%) to 60.48% when pulling 7f2a316aaf333b322c5a6ae746b834af4c604fc8 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.7%) to 60.39% when pulling 51727e87c88efba92d7dca023715155821c7f1a3 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.5%) to 60.246% when pulling 66093a9a5dbf9a910b29e33b76ace1a72cc05c72 on workspace into 7826c586994ffaea190bf8c5ae52e688abab8517 on master.

flanfly commented 7 years ago

Yay another 27k loc PR!