das-labor / panopticon

A libre cross-platform disassembler.
https://panopticon.re
GNU General Public License v3.0
1.43k stars 78 forks source link

Cleaned up UI #330

Closed sphinxc0re closed 7 years ago

sphinxc0re commented 7 years ago
sphinxc0re commented 7 years ago

I would like someone to test this on a different OS

m4b commented 7 years ago

Only thing I'd say is that at some future point I'd like to be able to move the sidebar's width; or have a collapse button even

sphinxc0re commented 7 years ago

@m4b Yes, I'm definitely with you on this but for now I think this is okay

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.01%) to 58.372% when pulling 6f62330e6ea01ff12259ddc9a2c2a390d7aabf98 on feature/ui_cleanup into 1f2f91d8390be95da94cc7b44834a5bc578efc04 on master.

sphinxc0re commented 7 years ago

Don't know what's wrong with travis. Builds seem to have passed

flanfly commented 7 years ago

When you want to know the OS you're running on you can look at the value of Qt.platform.os: http://doc.qt.io/qt-5/qml-qtqml-qt.html#platform-prop.

sphinxc0re commented 7 years ago

@flanfly I know, I already did that in 6f62330e6ea01ff12259ddc9a2c2a390d7aabf98

sphinxc0re commented 7 years ago

All tests are green although the GH UI doesn't show it

sphinxc0re commented 7 years ago

I restarted the jobs

flanfly commented 7 years ago

400px should be enough.

flanfly commented 7 years ago

👍

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 58.224% when pulling 07c53aec4fd966c5e874d39604b6d68e6a38978e on feature/ui_cleanup into 1f2f91d8390be95da94cc7b44834a5bc578efc04 on master.