search

dascandy / evoke

Magic build tool
Apache License 2.0
166 stars 17 forks source link

Replace boost::filesystem with std::filesystem #20

Closed n1toxyz closed 5 years ago

n1toxyz commented 5 years ago

I think it would make sense to use std instead of boost in this case. std::filesystem is modeled after boost::filesystem and almost the same except for a few wording changes. From what I can see all boost features used in this project have an almost one to one equivalent in the standard library. This would remove the boost dependency alltogether, which I believe is great, as it means that Evoke doesn't have any external dependencies.

dascandy commented 5 years ago

Thank you for this issue! Yes, I agree that it would make the first build of Evoke for a new user much better. It would also fix my Macbook issue - I can't figure out how to set up libraries properly there...

Let me see what I can do.

n1toxyz commented 5 years ago

You are welcome. I myself only recently stumbled upon std::filesystem. I really like the goal of your project, as I myself struggle sometimes with the other build system until I get it right.

MoAlyousef commented 5 years ago

Hello all, The problem is that boost process won’t handle std filesystem. This is known to boost-process authors: https://github.com/klemens-morgenstern/boost-process/issues/164

dascandy commented 5 years ago

@MoAlyousef doesn't your last pull request fix this too?

MoAlyousef commented 5 years ago

@MoAlyousef doesn't your last pull request fix this too?

It does.

dascandy commented 5 years ago

Thank you, @MoAlyousef for fixing this too!

MoAlyousef commented 5 years ago

Thank you, @MoAlyousef for fixing this too!

Most welcome!