Fix msvc link library - Githubissues

dascandy / evoke

Magic build tool

Apache License 2.0

166 stars 17 forks source link

Fix msvc link library #58

Closed xkbeyer closed 5 years ago

xkbeyer commented 5 years ago

Fixed msvc link command again.
Added unit test for clang/gcc/msvc getNNNCommand methods to support future refactorings. Since Boost.Test is already used, I stick with it.
Added the unit test project to CMakeLists. So that it will build and run with each build.
I didn't touch the Unity command, since I m´not sure how it is supposed to work.

dascandy commented 5 years ago

I have no idea why your last commit broke the CI builds. Can you check?

xkbeyer commented 5 years ago

The result of add_costum_command to run the unit tests fails. It looks like that the generated batch can't be run in the appvayor batch environment. Since I have no clue how to solve it, I will remove that for now.

xkbeyer commented 5 years ago

Is there a reason why on travis boost v1.64 is used? I assume it is just not updated, since on appveyor 1.69 is used. Could it be changed to 1.70 on both?

dascandy commented 5 years ago

Can be changed to 1.70 on both. I believe we had it to 1.64 to test that we were not relying on the latest and greatest, but just the 1.64 feature set (specifically process and interprocess).

dascandy commented 5 years ago

Merging as this is all fine. If you want to update Travis' boost update that's fine. Might need one build to remain on 1.64 to check that we don't move the goal posts along.