search

dascandy / evoke

Magic build tool
Apache License 2.0
166 stars 17 forks source link

Build with gcc8 fails #68

Closed xkbeyer closed 4 years ago

xkbeyer commented 5 years ago

Describe the bug Building the project with gcc8 fails with: evoke/fw/src/dotted.cpp:14:20: error: 'const class std::filesystem::__cxx11::path' has no member named 'filename_is_dot'; did you mean 'filename'? if (p.begin()->filename_is_dot())

System :

Additional context The std::filesystem does not have such a function. Since boost.filesystem and the std are not fully compatible. An example is this function. Others can be found here

I would suggest to stick with one and not to support both. Which one depends on which compilers should be supported.

Simerax commented 4 years ago

Agree, just tried building the project and ran into the same problem. @dascandy What do you think about this issue?

dascandy commented 4 years ago

Caused by problematic std::filesystem half integration and insufficient CI. Removed std::filesystem, using boost::filesystem everywhere, added more CI checks. Looking into making binary distribution possible at least for Mac, Windows and Ubuntu.

Can you check if this works properly now?

Simerax commented 4 years ago

I was able to build it now. 👍

xkbeyer commented 4 years ago

I can build it on Linux and Windows. Thanks.