search

dascandy / hippomocks

GNU Lesser General Public License v2.1
196 stars 67 forks source link

cpp11 branch make install is broken #77

Open rianquinn opened 7 years ago

rianquinn commented 7 years ago

Make install does not install any of the needed headers. 

/home/user/bfprefix/include/hippomocks.h:100:28: fatal error: detail/replace.h: No such file or directory
#include "detail/replace.h"
rianquinn commented 7 years ago

This is what I think the install code for CMake should look like

install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/hippomocks.h DESTINATION include)
install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/comsupport.h DESTINATION include)
install(DIRECTORY ${PROJECT_SOURCE_DIR}/HippoMocks/detail DESTINATION include)
dascandy commented 7 years ago

It needs the opposite fix actually; it should be available as a single header file again.

rianquinn commented 7 years ago

@dascandy one way to fix that if your trying to keep things clean would be to use CMake Install to merge the files for you. I'm pretty sure CMake can do that

rzr commented 6 years ago

Yes I can check this for next release

rianquinn commented 6 years ago

Any status on this?

rzr commented 6 years ago

yes cmake has install feature

What is the plan for next release ? should it only support cmake or both ?

Related: https://github.com/dascandy/hippomocks/pull/86

dascandy commented 6 years ago

@rianquinn I might as well fix this issue while watching your CppCon talk. I had no idea you were there presenting it.