Closed tobiasschweizer closed 5 years ago
@SepidehAlassi We will integrate the new runtime config on this branch, so you can merge into the Newton branch once it is ready
@tobiasschweizer That sounds good!
@kilchenmann @subotic
I updated the Knora-ui modules in https://github.com/dhlab-basel/beol/pull/118/commits/3fdbbe7431303814941b9c49786cc5aa61fd2998
Could you help me fix the test? There is a configuration problem:
Failed: StaticInjectorError(DynamicTestModule)[InjectionToken KuiCoreConfigToken (knora.core.config)]: StaticInjectorError(Platform: core)[InjectionToken KuiCoreConfigToken (knora.core.config)]: NullInjectorError: No provider for InjectionToken KuiCoreConfigToken (knora.core.config)!
in the specs, the following has to go into the config of providers:
providers: [
{ provide: KuiCoreConfigToken, useValue: KuiCoreConfig }
]
@subotic @kilchenmann
https://github.com/dhlab-basel/beol/pull/118/commits/5a00b38d4cf08feca69564349de340c155272a4e maybe fixes the issue. Could you please check if that is correct?
@SepidehAlassi I hope this works now. We have to check tomorrow.
@tobiasschweizer should I merge it to newton branch?
Please wait until I checked this PR with Ivan and Andrรฉ tomorrow
On 21 Feb 2019, at 19:16, Sepideh Alassi notifications@github.com<mailto:notifications@github.com> wrote:
@tobiasschweizerhttps://github.com/tobiasschweizer should I merge it to newton branch?
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dhlab-basel/beol/pull/118#issuecomment-466107389, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFuNlzR_U1XQbbZ_m5aIF4mpY5fdA7O3ks5vPuJ4gaJpZM4bHPGR.
LGTM! @SepidehAlassi i think you can merge it into your newton branch...
i think you can merge it into your newton branch...
@kilchenmann will do, thanks!
LGTM! @SepidehAlassi i think you can merge it into your newton branch..
@kilchenmann I merged in newton branch, but it does not work for me! should I change something in configuration?
I will have a look on it...right now Iโm on the way to basel
@SepidehAlassi I can't reproduce your errors. It works fine on my computer... Perhaps we need more information what you have done? Btw I just took the branch newton
and started the app with ng s
.
How did you run it? To configure the app you have to use the following file now: src/config/config.dev.json
. If you have to run it in productive mode ng s --prod
you should have a src/config/config.prod.json
file.
@kilchenmann Ah sorry, I had to simply restart the whole application after the merge. It was too late last night, did not think of it. Just ran the app without restarting, sorry for the inconvenience. all works now!
@kilchenmann @tobiasschweizer are you going to merge this to develope?
@SepidehAlassi But, you haven't merge this branch (wip/config-runtime
) into your newton branch? There's no commit about it.
@kilchenmann I have merged this branch into the newton branch locally to test if everything works. I have not commited/pushed this merge, because I believe it would be the best if you merge this branch into develop then I merge develop into newton branch. Don't you think?
Yes it would be the best practice to merge from develop. This is always better. There was another opinion here in the office ๐
Yes it would be the best practice to merge from develop. This is always better. There was another opinion here in the office ๐
good that we are all now in agreement. ๐
Adaptions for runtime config (https://github.com/dhlab-basel/Knora-ui/pull/180)
package.json
as to to be updated so it uses the new versions of knora-ui