search

dasch-swiss / beol

Bernoulli-Euler OnLine
https://beol.dasch.swiss
GNU Affero General Public License v3.0
0 stars 1 forks source link

refactor (app): runtime config #118

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

Adaptions for runtime config (https://github.com/dhlab-basel/Knora-ui/pull/180)

package.json as to to be updated so it uses the new versions of knora-ui

tobiasschweizer commented 5 years ago

@SepidehAlassi We will integrate the new runtime config on this branch, so you can merge into the Newton branch once it is ready

SepidehAlassi commented 5 years ago

@tobiasschweizer That sounds good!

tobiasschweizer commented 5 years ago

@kilchenmann @subotic

I updated the Knora-ui modules in https://github.com/dhlab-basel/beol/pull/118/commits/3fdbbe7431303814941b9c49786cc5aa61fd2998

Could you help me fix the test? There is a configuration problem:

Failed: StaticInjectorError(DynamicTestModule)[InjectionToken KuiCoreConfigToken (knora.core.config)]: StaticInjectorError(Platform: core)[InjectionToken KuiCoreConfigToken (knora.core.config)]: NullInjectorError: No provider for InjectionToken KuiCoreConfigToken (knora.core.config)!

tobiasschweizer commented 5 years ago

in the specs, the following has to go into the config of providers:

providers: [
    { provide: KuiCoreConfigToken, useValue: KuiCoreConfig }
]
tobiasschweizer commented 5 years ago

@subotic @kilchenmann

https://github.com/dhlab-basel/beol/pull/118/commits/5a00b38d4cf08feca69564349de340c155272a4e maybe fixes the issue. Could you please check if that is correct?

tobiasschweizer commented 5 years ago

@SepidehAlassi I hope this works now. We have to check tomorrow.

SepidehAlassi commented 5 years ago

@tobiasschweizer should I merge it to newton branch?

tobiasschweizer commented 5 years ago

Please wait until I checked this PR with Ivan and André tomorrow

On 21 Feb 2019, at 19:16, Sepideh Alassi notifications@github.com<mailto:notifications@github.com> wrote:

@tobiasschweizerhttps://github.com/tobiasschweizer should I merge it to newton branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dhlab-basel/beol/pull/118#issuecomment-466107389, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFuNlzR_U1XQbbZ_m5aIF4mpY5fdA7O3ks5vPuJ4gaJpZM4bHPGR.

kilchenmann commented 5 years ago

LGTM! @SepidehAlassi i think you can merge it into your newton branch...

SepidehAlassi commented 5 years ago

i think you can merge it into your newton branch...

@kilchenmann will do, thanks!

SepidehAlassi commented 5 years ago

LGTM! @SepidehAlassi i think you can merge it into your newton branch..

@kilchenmann I merged in newton branch, but it does not work for me! should I change something in configuration?

screenshot 2019-02-24 23 34 41
kilchenmann commented 5 years ago

I will have a look on it...right now I‘m on the way to basel

kilchenmann commented 5 years ago

@SepidehAlassi I can't reproduce your errors. It works fine on my computer... Perhaps we need more information what you have done? Btw I just took the branch newton and started the app with ng s. How did you run it? To configure the app you have to use the following file now: src/config/config.dev.json. If you have to run it in productive mode ng s --prod you should have a src/config/config.prod.json file.

SepidehAlassi commented 5 years ago

@kilchenmann Ah sorry, I had to simply restart the whole application after the merge. It was too late last night, did not think of it. Just ran the app without restarting, sorry for the inconvenience. all works now!

SepidehAlassi commented 5 years ago

@kilchenmann @tobiasschweizer are you going to merge this to develope?

kilchenmann commented 5 years ago

@SepidehAlassi But, you haven't merge this branch (wip/config-runtime) into your newton branch? There's no commit about it.

SepidehAlassi commented 5 years ago

@kilchenmann I have merged this branch into the newton branch locally to test if everything works. I have not commited/pushed this merge, because I believe it would be the best if you merge this branch into develop then I merge develop into newton branch. Don't you think?

kilchenmann commented 5 years ago

Yes it would be the best practice to merge from develop. This is always better. There was another opinion here in the office 🙊

SepidehAlassi commented 5 years ago

Yes it would be the best practice to merge from develop. This is always better. There was another opinion here in the office 🙊

good that we are all now in agreement. 😄