search

dasch-swiss / beol

Bernoulli-Euler OnLine
https://beol.dasch.swiss
GNU Affero General Public License v3.0
0 stars 1 forks source link

Letter: positioning of osdviewer and incoming links #125

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

There is a problem with the margin between the osdviewer and the incoming links section. This works in the resource template but not in the letter template. In the letter template, <section> is used.

screen shot 2019-03-06 at 2 48 55 pm
SepidehAlassi commented 5 years ago

@tobiasschweizer hmm, have you tried removing the enclosing section from images, making it simply as: <!-- Check for incoming images --> <kui-still-image #OSDViewer class="osd-viewer" *ngIf="resource?.incomingStillImageRepresentations?.length > 0;" [images]="resource?.stillImageRepresentationsToDisplay"> </kui-still-image>

It seems like when the image exceeds the dimension of the section, the location of succeeding components are not adapted.

tobiasschweizer commented 5 years ago

I will try that, thx!

SepidehAlassi commented 5 years ago

Sorry, I have not downloaded the new BEBB data yet, otherwise, I would have tried myself. Eduroam sucks in Library, the download would take 10 hours!

tobiasschweizer commented 5 years ago

Eduroam sucks in Library

obviously github does not check for explicit language :-)

Sorry, I have not downloaded the new BEBB data yet

no worries