Closed tobiasschweizer closed 5 years ago
@SepidehAlassi I am thinking about making the TEI link generation code a directive.
@tobiasschweizer that is a good idea!
@SepidehAlassi I made it a directive. It only creates a TEI link if there is a proper config element.
@SepidehAlassi Could you have a look at this PR?
@tobiasschweizer now that you have removed the config for the letter, is there anything I else I should change for checking this PR?
@SepidehAlassi you just have to provide the settings in the config (https://github.com/dhlab-basel/beol/blob/develop/src/config/config.dev.json) like in the test for the directive:
{
...
'tei': {
'http://0.0.0.0:3333/ontology/0801/beol/v2#letter': {
'textProperty': 'http://0.0.0.0:3333/ontology/0801/beol/v2#hasText',
'mappingIRI': 'http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF/mappings/BEOLTEIMapping',
'gravsearchTemplateIri': 'http://rdfh.ch/0801/templateIri',
'teiHeaderXSLTIri': 'http://rdfh.ch/0801/headerIri'
}
}
}
You get the settings when you run the Python script in Knora (https://github.com/dhlab-basel/Knora/blob/develop/webapi/_test_data/test_route/texts/beol/beolTEI.py).
But actually this PR is just about generating the link and display it, so it is actually enough to look at the directive.
@tobiasschweizer I see, now all works. I had a problem with configuration, it did not show me the link.
closes #76