dasch-swiss / beol

Bernoulli-Euler OnLine
https://beol.dasch.swiss
GNU Affero General Public License v3.0
0 stars 1 forks source link

Adapt list value component #139

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

This PR adapts the list value component so it gets the labels from ListCacheService.

This PR cannot be merged until we can use an updated version of Knora-ui containing ListCacheService.

.travis.yml temporarily uses yalc to run the tests.

flavens commented 5 years ago

travis.yml config

dist: xenial
sudo: required

services:
    - docker

language: node_js

node_js:
  - "11"

cache:
  yarn: true
  directories:
  - node_modules

addons:
  chrome: stable

install: 
  - yarn global add @angular/cli
  - yarn global add yalc
  - cd ~ && git clone -b wip/upgrade-to-angular7 https://github.com/dhlab-basel/Knora-ui.git && cd Knora-ui && yarn install --prod=false && yarn build-lib-prod && yarn yalc-publish
  - cd $TRAVIS_BUILD_DIR

script:
  - yalc remove --all && yarn yalc-add-modules
  - yarn install --prod=false
  - yarn test-ci
  - docker build .
tobiasschweizer commented 5 years ago

@SepidehAlassi This PR adapts beol so it gets list nodes using Knora's list route (subject index).

SepidehAlassi commented 5 years ago

@tobiasschweizer should I review this?

tobiasschweizer commented 5 years ago

should I review this?

We have to wait for the new Knora-ui modules to be provided by @flavens and @kilchenmann

SepidehAlassi commented 5 years ago

@tobiasschweizer knora-ui v.7.6.0 is available which works with Knora. v.7.0.0 Isn't the search for list nodes already a feature of Knora v.7.0.0?

tobiasschweizer commented 5 years ago

knora-ui v.7.6.0 is available which works with Knora. v.7.0.0 Isn't the search for list nodes already a feature of Knora v.7.0.0?

The problem is the way the list values are represented in v2 complex. There used to be the label's node name, but now there is just the IRI.

flavens commented 5 years ago

@tobiasschweizer where can I get the BEOL data?

tobiasschweizer commented 5 years ago

Thanks!