dasch-swiss / beol

Bernoulli-Euler OnLine
https://beol.dasch.swiss
GNU Affero General Public License v3.0
0 stars 1 forks source link

Wip/use knoraui viewer module #66

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

Use Knora UI modules to display values wherever possible and delete redundant local components.

This PR requires a new release of Knora UI wich will be available soon.

For development, the prelease builds are used.

closes #39 closes #40 closes #41

@SepidehAlassi I have refactored the templates so that they use the Knora UI modules wherever possible. Could you check if I broke anything? Not in the technical sense, but regarding the correct display of information.

The best way to test this PR locally is:

SepidehAlassi commented 5 years ago

check the pull request for correct presentation of leoo resources

SepidehAlassi commented 5 years ago

@tobiasschweizer there is a problem with introductions. the links from landing page to introductions are not working anymore

SepidehAlassi commented 5 years ago

@tobiasschweizer Same problem with introduction sections is also true for list of abbreviations. It is not accessible from landing page

tobiasschweizer commented 5 years ago

@SepidehAlassi I will look at it and see where the problem is.

tobiasschweizer commented 5 years ago

The introduction and the sections are working for me. I am still using the data that is currently on the productive server. Do you get an error message?

SepidehAlassi commented 5 years ago

@tobiasschweizer I was not getting an error message, there was simply nothing loaded. I tried it again right now with the new commit and it works! Can that be dependent on the core module update?!

tobiasschweizer commented 5 years ago

maybe. I made another build of the core module this morning and use it on this PR :-)

Is that PR ok now?

SepidehAlassi commented 5 years ago

yes, it is ok now as far as I see. I believe you can merge.

tobiasschweizer commented 5 years ago

Could you approve it ;-)